Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Proto columns #1991

Merged
merged 19 commits into from
May 15, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(spanner): fix db name
  • Loading branch information
harshachinta committed May 7, 2024
commit be162a9c110680701d7ae0be272109a7d0737596
6 changes: 3 additions & 3 deletions samples/system-test/spanner.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@
const ENCRYPTED_RESTORE_DATABASE_ID = `test-database-${CURRENT_TIME}-r-enc`;
const VERSION_RETENTION_DATABASE_ID = `test-database-${CURRENT_TIME}-v`;
const ENCRYPTED_DATABASE_ID = `test-database-${CURRENT_TIME}-enc`;
const PROTO_DATABASE_ID1 = `test-database-${CURRENT_TIME}-proto1`;
const PROTO_DATABASE_ID2 = `test-database-${CURRENT_TIME}-proto2`;
const PROTO_DATABASE_ID1 = `test-db${CURRENT_TIME}-proto1`;
const PROTO_DATABASE_ID2 = `test-db-${CURRENT_TIME}-proto2`;
const DEFAULT_LEADER_DATABASE_ID = `test-database-${CURRENT_TIME}-dl`;
const SEQUENCE_DATABASE_ID = `test-seq-database-${CURRENT_TIME}-r`;
const BACKUP_ID = `test-backup-${CURRENT_TIME}`;
Expand Down Expand Up @@ -1714,7 +1714,7 @@
});

// create_database_with_proto_descriptor
it('should create a database with a proto descriptor', async () => {
it.only('should create a database with a proto descriptor', async () => {

Check failure on line 1717 in samples/system-test/spanner.test.js

View workflow job for this annotation

GitHub Actions / lint

'it.only' is restricted from being used
const output = execSync(
`node database-create-with-proto-descriptor.js ${INSTANCE_ID} ${PROTO_DATABASE_ID1} ${PROJECT_ID}`
);
Expand Down
Loading