enhance: add scalar filtering and vector search latency metrics #34785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xianliang.li <[email protected]>
be6d6bc
to
d138380
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sre-ci-robot
pushed a commit
that referenced
this pull request
Jul 19, 2024
…#34783) issue: #34780 pr: #34785 Signed-off-by: xianliang.li <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34785 +/- ##
==========================================
- Coverage 84.44% 84.42% -0.02%
==========================================
Files 892 892
Lines 117014 117014
==========================================
- Hits 98807 98792 -15
- Misses 13836 13838 +2
- Partials 4371 4384 +13 |
smellthemoon
pushed a commit
to smellthemoon/milvus
that referenced
this pull request
Jul 26, 2024
…cs (milvus-io#34785)" This reverts commit 8e64bf9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add scalar filtering and vector search latency metrics to distinguish the cost of scalar filtering.
To add metrics in query chain, add a monitor module and move the metric files from original storage module.
issue: #34780