Upgraded to BufferGeometry #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think you could fix globe too? I've been trying but I haven't fixed it completely yet. I know it's alot to ask so a no is expected :) |
|
@DustinBrett Works for me. Thanks! |
|
@tengbao Any interest in basing dependency updates on this? |
@basgeertsema2000 This should be resolved in #143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally took the time to get this going on latest (r133) three.js with the new BufferGeometry.
Fix for #101
I based a good amount of my changes on https://sbcode.net/threejs/geometry-to-buffergeometry/
Works on my machine ;-)