Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect SmolStr's De/Serialize implementation #14982

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Reflect SmolStr's De/Serialize implementation #14982

merged 2 commits into from
Sep 2, 2024

Conversation

bushrat011899
Copy link
Contributor

Objective

Solution

  • Added Deserialize to the list of reflected traits for SmolStr

Testing

  • CI passed locally.

@bushrat011899 bushrat011899 added C-Enhancement A new feature D-Trivial Nice and easy! A great choice to get started with Bevy A-Reflection Runtime information about types X-Uncontroversial This work is generally agreed upon D-Macros Code that generates Rust code S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 30, 2024
killercup
killercup approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@killercup killercup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Serde is already in tree.

@bushrat011899 bushrat011899 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 1, 2024
alice-i-cecile
alice-i-cecile requested changes Sep 2, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Serialize should be reflected here too.

@alice-i-cecile alice-i-cecile mentioned this pull request Sep 2, 2024
Closed
@alice-i-cecile alice-i-cecile added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Sep 2, 2024
@bushrat011899 bushrat011899 changed the title Reflect SmolStr's Deserialize implementation Reflect SmolStr's De/Serialize implementation Sep 2, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 2, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Sep 2, 2024
Merged via the queue into bevyengine:main with commit 547b1c7 Sep 2, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killercup killercup killercup approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@UkoeHB UkoeHB UkoeHB approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Enhancement A new feature D-Macros Code that generates Rust code D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SmolStr doesn't have ReflectDeserialize
4 participants
@bushrat011899 @killercup @alice-i-cecile @UkoeHB