Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MecanumDrive odometry and tf functions implementation #1665

Closed
wants to merge 2 commits into from

Conversation

danilogsch
Copy link

@danilogsch danilogsch commented Aug 25, 2022

Signed-off-by: danilo_gsch [email protected]
Danilo Schneider

🎉 New feature

Closes #683 #1619

Summary

Implementation of Mecanum drive odometry and tf based on the implementation of the Differential robot.

Test it

Run mecanum_drive.sdf and listen for odometry and tf topics.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@danilogsch
Copy link
Author

Depends on #486

@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Aug 26, 2022
@chapulina chapulina moved this from Inbox to In review in Core development Aug 26, 2022
@chapulina chapulina added the enhancement New feature or request label Aug 26, 2022
@azeey
Copy link
Contributor

azeey commented Nov 21, 2022

Waiting on gazebosim/gz-math#486

@mjcarroll
Copy link
Contributor

@danilogsch if you can address feedback on the math pull request, I can begin reviewing this one.

@mjcarroll mjcarroll moved this from In review to In progress in Core development Mar 20, 2023
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023
@mjcarroll
Copy link
Contributor

@danilogsch the math PR has been landed, can you add a test here to verify the behavior of the system?

@azeey azeey removed the beta Targeting beta release of upcoming collection label Aug 30, 2023
@azeey
Copy link
Contributor

azeey commented Aug 30, 2023

I've removed the beta label. We can merge this after Harmonic is released.

@muttistefano
Copy link

Hi all, any information regarding when this PR will be included?
I see some failures in the automatic build, is this due to the PR or still the math dependency ?
In case I can help.
Thanks

@azeey azeey removed the needs upstream release Blocked by a release of an upstream library label Jan 12, 2024
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 29, 2024
@azeey
Copy link
Contributor

azeey commented Aug 8, 2024

I didn't realize #2297 replaced this. Closing.

@azeey azeey closed this Aug 8, 2024
@azeey azeey removed the beta Targeting beta release of upcoming collection label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🏯 fortress Ignition Fortress
Projects
Status: Done
Core development
In progress
Development

Successfully merging this pull request may close these issues.

None yet

5 participants