Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Joint forces #2369

Open
wants to merge 3 commits into
base: gz-sim8
Choose a base branch
from

Conversation

Fixit-Davide
Copy link

@Fixit-Davide Fixit-Davide commented Apr 12, 2024

🦟 Bug fix

Fixes #883

Summary

These changes should allow to obtain information regarding the forces applied to the joints.

Test it

  • Pull gz-physics PR: [featherstone] Publish JointFeedback forces. gz-physics#628
  • Launch gz sim --physics-engine gz-physics-bullet-featherstone-plugin lift_drag.sdf simulation.
  • Send a command to the model (gz topic -t "/model/lift_drag_demo_model/joint/rod_1_joint/cmd_force" -m gz.msgs.Double -p "data: 0.8").
  • Echo the topic: gz topic -e -t /world/lift_drag/model/lift_drag_demo_model/joint_state

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Apr 12, 2024
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind to sign the commit ?

Signed-off-by: Davide Graziato <[email protected]>
Signed-off-by: Davide Graziato <[email protected]>
@azeey
Copy link
Contributor

azeey commented Apr 12, 2024

Also, can you please add a test?

@Fixit-Davide
Copy link
Author

I have just made a PR in gz-physics in order to populate the force fields while using bullet-featherstone. I added some information on how to test the code there (I have reported them here also).

iche033
iche033 previously approved these changes Apr 24, 2024
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you please add a test?

oh just saw that a test was requested.

@iche033 iche033 dismissed their stale review April 24, 2024 00:27

waiting for a test to be added

#include "gz/sim/components/JointVelocity.hh"
#include "gz/sim/components/JointVelocityCmd.hh"
#include "gz/sim/components/JointVelocityLimitsCmd.hh"
#include "gz/sim/components/JointVelocityReset.hh"
#include "gz/sim/components/JointForce.hh"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI warning:

"gz/sim/components/JointForce.hh" already included at /github/workspace/src/systems/physics/Physics.cc:119  

@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 29, 2024
@azeey
Copy link
Contributor

azeey commented Aug 6, 2024

@Fixit-Davide we are now in Feature freeze for Gazebo Ionic. Since PR is already open, I've applied the beta label which means it's slotted for the Ionic release if we can get it merged before 08/28/2024. Do you think that's feasible? If not, please let me know and I'll remove the beta label.

@azeey
Copy link
Contributor

azeey commented Aug 12, 2024

To focus our efforts on the Ionic release, I'll go ahead and remove the beta label from this. I encourage you to respond to the feedback, but we'll hold off from merging this until Ionic is released.

@azeey azeey removed the beta Targeting beta release of upcoming collection label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

JointStatePublisher does not publish efforts
4 participants