Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 8 -> main #2533

Merged
merged 20 commits into from
Aug 26, 2024
Merged

Merge 8 -> main #2533

merged 20 commits into from
Aug 26, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 21, 2024

➡️ Forward port

Port gz-sim8 to main

Branch comparison: main...gz-sim8

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

nkoenig and others added 18 commits July 3, 2024 05:17
* Resolve failing tests

Signed-off-by: Nate Koenig <[email protected]>

* Cleanup

Signed-off-by: Nate Koenig <[email protected]>

* Update src/EntityComponentManager.cc

Co-authored-by: Ian Chen <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>

* Incorrect else

Signed-off-by: Nate Koenig <[email protected]>

---------

Signed-off-by: Nate Koenig <[email protected]>
Co-authored-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Adds support for Spacecraft thrusters controlled with a duty cycle signal (such as PWM).

---------

Signed-off-by: Pedro Roque <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Benjamin Perseghetti <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Specifying an integer value in a <gz:system_priority> tag
for a system will control the order in which System PreUpdate
and Update callbacks are executed, with lower values executing
first.

The PriorityPrinter example plugin is added to illustrate
the feature.

Signed-off-by: Steve Peters <[email protected]>
Restores the behavior where the `Configure` function of model plugins are called before the model's parent entity is set.
---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
@iche033
Copy link
Contributor Author

iche033 commented Aug 21, 2024

I've seen UNIT_Server_TEST test failed before but it looks like it is now failing consistently on all CI builds. The test passes locally. Checking if it's introduced by this forward port PR or if there are timing changes that made it easier to fail now.

@iche033
Copy link
Contributor Author

iche033 commented Aug 22, 2024

there are also new compile warnings in main. I created a separate PR to fix them: #2535

@azeey
Copy link
Contributor

azeey commented Aug 23, 2024

Rerunning the Noble Github Actions job. I think the failures was flaky.

@iche033
Copy link
Contributor Author

iche033 commented Aug 23, 2024

looks like the INTEGRATION_log_system test is failing consistently on ubuntu noble github actions

@iche033
Copy link
Contributor Author

iche033 commented Aug 23, 2024

looks like the INTEGRATION_log_system test is failing consistently on ubuntu noble github actions

created #2539 to see if it fixes the test

@iche033
Copy link
Contributor Author

iche033 commented Aug 26, 2024

INTEGRATION_log_system test is fixed. I think the windows INTEGRATION_save_world is flaky. I've seen it fail before.

Merging.

@iche033 iche033 merged commit 19801c8 into main Aug 26, 2024
8 of 9 checks passed
@iche033 iche033 deleted the merge_20240821 branch August 26, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

8 participants